Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Support for react-native-macos #144

Open
es-lynn opened this issue Dec 17, 2020 · 1 comment
Open

Basic Support for react-native-macos #144

es-lynn opened this issue Dec 17, 2020 · 1 comment
Labels
help wanted Extra attention is needed macos

Comments

@es-lynn
Copy link

es-lynn commented Dec 17, 2020

Is your feature request related to a problem? Please describe.

Storybook layout is broken in react-native-macos.

storybook2

  1. There is a giant white section blocking half of Storybook
  2. Story list cannot be viewed
  3. Stories cannot be selected
  4. Addons cannot be selected
  5. Component preview disappears out of sight when selecting Navigator or Addons tab

Describe the solution you'd like

It would be nice if Storybook could add basic support for MacOS, so that components can at least be previewed.

While I understand MacOS is not the supported market at the moment, there is only one component that is broken and needs to be fixed to provide a basic level of support.

Primary
1) Ability to preview components without it being obstructed

Secondary (these are non-critical as it can be controlled from react-native-storybook-server)
2) Ability to view stories from storylist
3) Ability to select stories from storylist
4) Ability to interact with addons

Tertiary
5) Component preview does not fly off screen

Describe alternatives you've considered

I've upgraded to storybook-6.0.0-alpha but there was no difference.

Are you able to assist bring the feature to reality?

Maybe, with guidance.

Additional context

Part of the problem lies with the following file: OnDeviceUI/index#160-165

storybook2b

For some reason, the Panel does not move together with its contents and it gets stuck to the left side of the page. When I change the backgroundColor of Panel to transparent, the white sections disappear and I'm able to view my component.

storybook2c

Because there are 2 panels located on the left side, I'm not able to select my storybook. After commenting out the Actions Panel, I'm able to select my stories.

@dannyhw
Copy link
Member

dannyhw commented Dec 19, 2020

@aelesia hey thanks so much for the detailed issue! I actually tried to run this recently and I wasn't able to get the example project to work with macos at all, I think due to issues with yarn workspaces.

Are the examples in your gif from your own project? I'm having troubles getting things working on the example project, what steps did you follow to make this work?

I'm definitely intrested in adding support for macos/windows I'm just having trouble getting an example working on my machine.

@dannyhw dannyhw added help wanted Extra attention is needed macos labels Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed macos
Projects
None yet
Development

No branches or pull requests

2 participants