Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinman code needs PEP-8 style support #171

Open
bobinson opened this issue Oct 29, 2018 · 0 comments
Open

Tinman code needs PEP-8 style support #171

bobinson opened this issue Oct 29, 2018 · 0 comments

Comments

@bobinson
Copy link
Contributor

What

PEP-8 is from the Zen of Python. For the non-religious, non-zen minds, a definition is : A Foolish Consistency is the Hobgoblin of Little Minds

Why

PEP-8 gives a universal, easy to understand coding style to Python code. Further the popular IDEs has support for this.

This will help the maintainability of the code base and help to increase community contributions.

Steemit's other repostories

In the case of Steemit code base, Steen-Python is PEP8 compliant. CircleCI is running tests for the same. Eg: https://circleci.com/gh/steemit/steem-python/584

Tests are included in the case of steam-python : https://github.com/steemit/steem-python/blob/267d41e4c9f4d7d01fa85ecd5bef9f3fdbfc7793/setup.py

How to do it ?

I would recommend to manually do it as the code base is evolving and the manual implementation will also give an opportunity to review the code base and find other areas of improvement. ie it will double as a peer code review. #162 is a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant