Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes and string generators #52

Open
pascutto opened this issue Apr 26, 2019 · 0 comments
Open

Bytes and string generators #52

pascutto opened this issue Apr 26, 2019 · 0 comments

Comments

@pascutto
Copy link
Contributor

Hi !
First of all thanks for this great tool !

I've been willing to use it over the past few days, and when I needed to generate bytes and strings, I realized:

  • There is no bytes gen generator.
  • val bytes : string gen sounds a bit confusing to me ; as I expected it either to be named string or to return a bytes gen.

Of course, one could easily use map to get a string gen out of a bytes gen, but it would also probably be easier to use and understand if Crowbar could provide generators for basic types, named accordingly.

So, here is my proposal (I'd be happy to open a PR for that):

  • Rename bytes to string (since it returns a string gen).
  • Add val bytes : bytes gen.
    These would obviously be breaking changes, so let me know what you think :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant