Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default requests for cpu to 10m and change to QoS #236

Open
rasheedamir opened this issue Mar 24, 2023 · 3 comments
Open

Reduce default requests for cpu to 10m and change to QoS #236

rasheedamir opened this issue Mar 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@rasheedamir
Copy link
Member

https://github.com/stakater/application/blob/master/application/values.yaml#L213-L220

  • reduce to 10m
  • reduce to 50MB

and set same limits

@rasheedamir
Copy link
Member Author

@d3adb5 @aslafy-z any thoughts/comments about this one?

@d3adb5
Copy link
Collaborator

d3adb5 commented Jul 7, 2023

Usually Helm charts don't set resource constraints by default, so that chart users may size the applications up to fit specific deployments. The preferred QoS class is also highly dependent on each deployment.

Since this project is meant as a generic Helm chart for stateless applications following a specific set of criteria, I'd avoid setting constraints by default to make it as easy as can be for anybody to use the chart.

@rasheedamir
Copy link
Member Author

Great observation, @d3adb5! Our approach is to make this opinionated while incorporating essential best practices. We're considering establishing absolute minimum requests and limits within the Helm chart. But indeed this is debatable

@karl-johan-grahn karl-johan-grahn added the enhancement New feature or request label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants