Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate dependency graph issues #231

Closed
codefromthecrypt opened this issue Mar 28, 2016 · 4 comments
Closed

investigate dependency graph issues #231

codefromthecrypt opened this issue Mar 28, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@codefromthecrypt
Copy link
Contributor

I've heard from @joshlong and @marcingrzejszczak that sleuth'd traces aren't showing up in zipkin's UI dependency graph view.

The dependency graph view is special cased for zipkin "server" annotations. That's due to a number of reasons, including keeping the rules simple, the input data small and avoiding double-counting.

The following patterns will trigger nodes in the dependency tree.

  • server span
    • A span has a SERVER_RECV("sr") annotation, but no CLIENT_ADDR("ca")
  • uninstrumented client+server span
    • A span has a CLIENT_ADDR("ca") binary annotation and a SERVER_RECV("sr") annotation
    • A span has both CLIENT_ADDR("ca") and SERVER_ADDR("sa") binary annotations
  • client-only span
    • A span has a SERVER_ADDR("sa") binary annotation, but no SERVER_RECV("sr")

If sleuthed spans don't produce combinations like above, stop here, and try and figure out why or what's missing.

If sleuthed spans look right per above, yet no dependency graph is showing up in either mem or mysql storage...

catch a trace via http://zipkinhost:9411/api/v1/trace/your_trace_id and ask about it in https://gitter.im/openzipkin/zipkin, preferably a pared down trace (vs one with a 100+ spans).

If you want details, there are a number of tests that account for behaviors, addressing specific instrumentation use cases.
https://github.com/openzipkin/zipkin-java/blob/master/zipkin/src/test/java/zipkin/internal/DependencyLinkSpanTest.java
https://github.com/openzipkin/zipkin-java/blob/master/zipkin/src/test/java/zipkin/internal/DependencyLinkerTest.java
https://github.com/openzipkin/zipkin-java/blob/master/zipkin/src/test/java/zipkin/DependenciesTest.java

@codefromthecrypt
Copy link
Contributor Author

ps added this to try and find a good place to document this in a way that doesn't require familiarity with java openzipkin/openzipkin.github.io#13

@marcingrzejszczak
Copy link
Contributor

There are still issues in messaging and Zuul

@marcingrzejszczak
Copy link
Contributor

shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
@marcingrzejszczak
Copy link
Contributor

Messaging fixed in caba82c

Zuul fixed in b3c78c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants