From 3cac2fdbea90e8e758a8eef69f94506746bb5874 Mon Sep 17 00:00:00 2001
From: Tim Van Dijck <tim.van.dijck@gmail.com>
Date: Fri, 3 May 2024 15:22:31 +0200
Subject: [PATCH] Fix an issue where the same mediaCollections could be
 registered multiple times. (#3598)

---
 src/InteractsWithMedia.php                    |  2 +-
 .../GetRegisteredMediaCollections.php         | 24 +++++++++++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 tests/MediaCollections/GetRegisteredMediaCollections.php

diff --git a/src/InteractsWithMedia.php b/src/InteractsWithMedia.php
index 4420ed751..8e998a869 100644
--- a/src/InteractsWithMedia.php
+++ b/src/InteractsWithMedia.php
@@ -508,7 +508,7 @@ public function addMediaCollection(string $name): MediaCollection
     {
         $mediaCollection = MediaCollection::create($name);
 
-        $this->mediaCollections[] = $mediaCollection;
+        $this->mediaCollections[$name] = $mediaCollection;
 
         return $mediaCollection;
     }
diff --git a/tests/MediaCollections/GetRegisteredMediaCollections.php b/tests/MediaCollections/GetRegisteredMediaCollections.php
new file mode 100644
index 000000000..4c89360f1
--- /dev/null
+++ b/tests/MediaCollections/GetRegisteredMediaCollections.php
@@ -0,0 +1,24 @@
+<?php
+
+use Spatie\MediaLibrary\Tests\TestSupport\TestModels\TestModelWithConversion;
+
+it('calling getRegisteredMediaCollections multiple times should return the same result', function () {
+    $testModel = new class() extends TestModelWithConversion
+    {
+        public function registerMediaCollections(): void
+        {
+            $this->addMediaCollection('images')
+                ->useDisk('secondMediaDisk');
+        }
+    };
+
+    $result = $testModel->getRegisteredMediaCollections();
+    ray($result);
+
+    expect($result)->toHaveCount(1);
+
+    $result = $testModel->getRegisteredMediaCollections();
+    ray($result);
+
+    expect($result)->toHaveCount(1);
+});