No Modbridge Lifts.

[UnknownShifter]

Since the project has been revived, lifts have been fixed. Which is wonderful! But, a majority of us peoples use Modbridge/Medbridge, and there aren't lifts for those kind of models. Modbridge itself has lift models, but no actual lifts. Would you be able to add them?

[nirahiel]

I can try.
Le 25 juin 2016 06:28, "UnknownShifter" notifications@github.com a écrit :

Since the project has been revived, lifts have been fixed. Which is
wonderful! But, a majority of us peoples use Modbridge/Medbridge, and there
aren't lifts for those kind of models. Modbridge itself has lift models,
but no actual lifts. Would you be able to add them?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#94, or mute the thread
https://github.com/notifications/unsubscribe/AAs2hPZbEqXzrl3YhCzXt-gfpTBC6-gLks5qPK5SgaJpZM4I-Q6t
.

[UnknownShifter]

Alrighty, thanks!

[X-Coder]

@nirahiel, I removed lots of the abbreviations a few minutes ago in the lua code of lift system desinger. This should make it a bit easier to add new stuff.

[nirahiel]

Okay will check in a few days. Not home right now
Le 26 juin 2016 00:27, "X-Coder" notifications@github.com a écrit :

@nirahiel https://github.com/nirahiel, I removed lots of the
abbreviations a few minutes ago in the lua code of lift system desinger.
This should make it a bit easier to add new stuff.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#94 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAs2hBRipSKioiqF8jzSjFV00E47egdcks5qPattgaJpZM4I-Q6t
.

[X-Coder]

Did you already started?

[nirahiel]

Not yet. I've been really busy. But I have write access so no worries I'll
do my thing on a separate branch and we'll see if that works.
Le 26 juin 2016 00:29, "X-Coder" notifications@github.com a écrit :

Did you already started?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#94 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAs2hCR6-52LWbZFFZIWm1rkOoMa4Dotks5qPavDgaJpZM4I-Q6t
.

[X-Coder]

@nirahiel, had some time today and started to work on it.
If you have some time (or any one :) you can help to get it working on the new branch called LiftSystemDesigner I just commited.

The UI for selecting between modbridge- / smallbridge-type I already modified. I changed the Door-/Hatch-Listview into a equipment one, so there can be added different equipment setups based on the selected type. Skin and Size can be selected based too on the type. New types can be added just by extending the SetTable. Later with sb4 we can change it more class-like and add API.

Right now the offsets and orientations are a bit messed up because lot of it was hard-coded for smallbridge. I feel these hard-coded offsets and orientation stuff should be moved into the lift model table (LMT) all together, so we can keep all model-related stuff (angle, orientation, offset, center) in the table-definition and add new models in the future just by modifying this definition.

I played with the offsets in the last commit, had not much luck with it, feel free to change it. Also the model access table (LMT..AT) for modbridge is wrong, I just changed it to 1,1,1,1 to get the lift show up, but it should look like the one smallbridge is using, 1 stands for a open side.

TODO:

• getting rid of abbrevations most of it
• new UI for type selection
• allowing a variable number of equipment setups instead of just doors and hatches
• change modbridge-parts orientation to same as the smallbridge parts is using (think its 90° clockwise)
• move all hard-coded type related stuff (smallbridge-offsets, angles...) to LMT definition so we can use the same code for all settypes (optional, wip)
• fix modbrige model access table (LMT.MODBRIDGE.S.AT)
• fix offset for the lift
• fix movement to right floor
• lift model needs to be changed to the one with two open sides if there is a part with two open sides
• lift model ghost too
• fix frozen lift panel (wire buttons too) after paste (needs Wake() somewhere?)
• hide/remove not needed icons in the designer-UI based on the selected type
• change icons based on the selected type
• adding sounds
  -adding shake effects
• adding doors
• adding hatches
• adding glass models
• adding the large modbridge model
• adding long leg lift model (into LMT.MODBRIDGE.L?, +find a way to not spawn the bottom part when the lift model is used, add a new option into LMT.MODBRIGE.S.SD to disable spawing of the bottom part?)
• sb4: organize code better: make use of snake's new class model, implement API for allowing adding more types, equipment, skins

[nirahiel]

@X-Coder I could use your Skype if you have one.
Also I fixed offset for the lift in my own repo, idk if that's the best way to do it, but it works.
Check here : https://github.com/nirahiel/sbep/commit/54a4caa2f963ad77ddab01f3b764edd0f4c9ecb1
Will see if I can fix other things too.
Also for the 1,1,1,1 thing, we don't have a ton of lift models, do we ? (if we do have all combos, aka, 4 exits, 3 exits, 2 exits in line, 2 exits in L, 1 exit, then i'll be happy to fix that 1,1,1,1 issue. Otherwise i'll use the same platform for the different possibilities)

EDIT : Looks like I fixed more things, i'll do a new commit soon.

[X-Coder]

@nirahiel I don't use Skype, only Steam, did sent you a invitation.
Your fixes works fine. The panel is spawned with wrong rotation when you spawn the prop with one exit first and prop with two exit second, do you know why this happens?.

I started moving some more stuff to PMT, and adding sounds.

[X-Coder]

@nirahiel, just pushed the changes and your fixes into LiftSystemDesigner branch.