From 87e935adc9aeef6938015e445030caa81bd4fba3 Mon Sep 17 00:00:00 2001 From: Vadim Smakhtin Date: Wed, 23 Oct 2024 12:20:58 +0200 Subject: [PATCH] Improvement/feature flags cleanup (#1908) * Cleanup dotphin feature flags * Removed coming soon * Fix --- .../src/lib/features/MultipassStates.ts | 7 +------ .../src/lib/shared/i18n/en/index.ts | 5 ++--- .../src/lib/shared/i18n/i18n-types.ts | 8 ++++---- .../src/lib/shared/siteConfigs.ts | 2 -- .../widgets/MultipassCTA/MultipassCTA.svelte | 16 +++++----------- .../src/routes/+page.svelte | 19 ++++++------------- 6 files changed, 18 insertions(+), 39 deletions(-) diff --git a/apps/verification-portal/src/lib/features/MultipassStates.ts b/apps/verification-portal/src/lib/features/MultipassStates.ts index 36817e9d0..c512a35db 100644 --- a/apps/verification-portal/src/lib/features/MultipassStates.ts +++ b/apps/verification-portal/src/lib/features/MultipassStates.ts @@ -1,10 +1,6 @@ import { writable, derived } from 'svelte/store'; import type { DeepAsset } from '@sni/types'; -import { isFeatureEnabled } from '$lib/shared/utils'; - -const canEvolve = isFeatureEnabled('dotphinEvolution'); - import { MAX_EVOLUTION_LEVEL, initialStepConfig, @@ -142,8 +138,7 @@ export const multipassStepConfig = derived( // Retrieve the disabled status from the initial configuration const nftDisabled = initialStepConfig.nft.disabled; - const evolutionDisabled = - initialStepConfig.evolution.disabled && !canEvolve; + const evolutionDisabled = initialStepConfig.evolution.disabled && false; // NFT step is locked if the user is logged out or disabled; otherwise, check other conditions const nftStatus = diff --git a/apps/verification-portal/src/lib/shared/i18n/en/index.ts b/apps/verification-portal/src/lib/shared/i18n/en/index.ts index 3ebb805ca..6b31de5a9 100644 --- a/apps/verification-portal/src/lib/shared/i18n/en/index.ts +++ b/apps/verification-portal/src/lib/shared/i18n/en/index.ts @@ -198,10 +198,9 @@ const en: BaseTranslation = { CLAIMED: {}, }, evolveStep: { - stepTitle: 'Evolution (coming soon)', + stepTitle: 'Evolution', INITIAL: { - subtitle: - 'Coming soon. You need to have a DOTphin Orbo to start evolving', + subtitle: 'You need to have a DOTphin Orbo to start evolving', cta: 'Evolve', moreInfo: 'Read more', }, diff --git a/apps/verification-portal/src/lib/shared/i18n/i18n-types.ts b/apps/verification-portal/src/lib/shared/i18n/i18n-types.ts index be67a3e3d..1e11ca74d 100644 --- a/apps/verification-portal/src/lib/shared/i18n/i18n-types.ts +++ b/apps/verification-portal/src/lib/shared/i18n/i18n-types.ts @@ -564,12 +564,12 @@ type RootTranslation = { } evolveStep: { /** - * E​v​o​l​u​t​i​o​n​ ​(​c​o​m​i​n​g​ ​s​o​o​n​) + * E​v​o​l​u​t​i​o​n */ stepTitle: string INITIAL: { /** - * C​o​m​i​n​g​ ​s​o​o​n​.​ ​Y​o​u​ ​n​e​e​d​ ​t​o​ ​h​a​v​e​ ​a​ ​D​O​T​p​h​i​n​ ​O​r​b​o​ ​t​o​ ​s​t​a​r​t​ ​e​v​o​l​v​i​n​g + * Y​o​u​ ​n​e​e​d​ ​t​o​ ​h​a​v​e​ ​a​ ​D​O​T​p​h​i​n​ ​O​r​b​o​ ​t​o​ ​s​t​a​r​t​ ​e​v​o​l​v​i​n​g */ subtitle: string /** @@ -1286,12 +1286,12 @@ export type TranslationFunctions = { } evolveStep: { /** - * Evolution (coming soon) + * Evolution */ stepTitle: () => LocalizedString INITIAL: { /** - * Coming soon. You need to have a DOTphin Orbo to start evolving + * You need to have a DOTphin Orbo to start evolving */ subtitle: () => LocalizedString /** diff --git a/apps/verification-portal/src/lib/shared/siteConfigs.ts b/apps/verification-portal/src/lib/shared/siteConfigs.ts index dd3815026..b919ee6d9 100644 --- a/apps/verification-portal/src/lib/shared/siteConfigs.ts +++ b/apps/verification-portal/src/lib/shared/siteConfigs.ts @@ -5,8 +5,6 @@ export default { feature: { collectionsTest: false, multipassTest: false, - dotphinWidget: true, - dotphinEvolution: false, }, social: { discord: 'discord:https://discord.gg/ZXyC3tN87K', diff --git a/apps/verification-portal/src/lib/widgets/MultipassCTA/MultipassCTA.svelte b/apps/verification-portal/src/lib/widgets/MultipassCTA/MultipassCTA.svelte index f52fd2a55..1127a356f 100644 --- a/apps/verification-portal/src/lib/widgets/MultipassCTA/MultipassCTA.svelte +++ b/apps/verification-portal/src/lib/widgets/MultipassCTA/MultipassCTA.svelte @@ -5,9 +5,6 @@ import LL from '$lib/shared/i18n/i18n-svelte'; export let name: string; export let infoLink: string | undefined; - import { isFeatureEnabled } from '$lib/shared/utils'; - - const showDotphin = isFeatureEnabled('dotphinWidget');
- {#if !showDotphin} - - {$LL.assets.multipass.comingSoon()} - {/if} + + {$LL.assets.multipass.comingSoon()} @@ -61,7 +55,7 @@ color="none" class="z-50 hover:bg-primary-300 bg-primary-400 text-white rounded-sm border-none !py-2.5 !px-4 text-lg uppercase" type="button" - tabindex="1" + tabindex={1} href={infoLink} target="_blank" > diff --git a/apps/verification-portal/src/routes/+page.svelte b/apps/verification-portal/src/routes/+page.svelte index d350be5d0..aba3718a9 100644 --- a/apps/verification-portal/src/routes/+page.svelte +++ b/apps/verification-portal/src/routes/+page.svelte @@ -6,9 +6,6 @@ import CollectionsTabs from '$lib/widgets/CollectionTabs/CollectionTabs.svelte'; import DoTphinTimelineWrapper from '$lib/widgets/DOTphin/TimelineWrapper.svelte'; import { LL } from '$lib/shared/i18n/i18n-svelte'; - import { isFeatureEnabled } from '$lib/shared/utils'; - - const showDotphin = isFeatureEnabled('dotphinWidget'); export let data; @@ -39,17 +36,13 @@ > {$LL.subtitle()} - {#if showDotphin} - See all collections - {/if} + See all collections
- {#if showDotphin} - - {/if} +
{#await data.streamed.highlights then highlights}