Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy.cc:strings need to be marked for translation #118

Open
andy5995 opened this issue Sep 3, 2018 · 4 comments
Open

Fuzzy.cc:strings need to be marked for translation #118

andy5995 opened this issue Sep 3, 2018 · 4 comments

Comments

@andy5995
Copy link
Contributor

andy5995 commented Sep 3, 2018

There are strings in this file that need to be marked for translation.

cout << "hlfuzzy: keys: " << count << '\n';

@shrey183
Copy link
Contributor

shrey183 commented Oct 4, 2018

Hi, I would love to work on this issue, but I am not sure I understand your requirement. Could you give an example?

@solbu
Copy link
Owner

solbu commented Oct 5, 2018

If you look on line 169 you find a string that is not makred for translation, but on line 175 and 176, some 6 lines below that, you'll see an example of strings that are marked for translation.

For example, in the line 169 you find this code:
cout << "hlfuzzy: words: " << count << '\n';
The quoted string need to be enclosed in _().

Here is an example.
I'll have the original just below so you see the difference easily:
cout << _("hlfuzzy: words: ") << count << '\n'; << Fixed
cout << "hlfuzzy: words: " << count << '\n'; << Original

@shrey183
Copy link
Contributor

shrey183 commented Oct 5, 2018

Hi, thanks for your comment, I created a Pull Request and I see this after making the pull request:
image

Have I done something wrong? I am kind of new to this, so any comments from you all would be really helpful.

@solbu
Copy link
Owner

solbu commented Oct 5, 2018

This is exactly how it's done. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants