Confusing method names in LocalParameters? #917
thomascorthals
started this conversation in
Ideas
Replies: 2 comments
-
This is a better example of how it's confusing because it directly shows the inconsistency in the usage of add vs. set. solarium/src/QueryType/Select/Query/FilterQuery.php Lines 66 to 92 in ada911c |
Beta Was this translation helpful? Give feedback.
0 replies
-
@thomascorthals |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
#884 got me wondering about this:
solarium/src/Core/Query/LocalParameters/LocalParameters.php
Lines 98 to 132 in a5bb12e
setExclude()
actually adds one exclude, the same wayaddExcludes()
can add multiple excludes, instead of overwriting previously set excludes the waysetExcludes()
does. This isn't intuitive and not mentioned in the docs.Beta Was this translation helpful? Give feedback.
All reactions