Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message::{into_text,to_text} could use a more specific error type #438

Open
wackbyte opened this issue Aug 19, 2024 · 0 comments
Open

Message::{into_text,to_text} could use a more specific error type #438

wackbyte opened this issue Aug 19, 2024 · 0 comments

Comments

@wackbyte
Copy link

The into_text and to_text methods on Message currently return a Result with tungstenite's error type even though the only error they can produce is a UTF-8 error. I suggest that they use FromUtf8Error and Utf8Error like Frame's into_string and to_text methods.

(Also, Message::into_text and Frame::into_string are named inconsistently...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant