How do I skip shapes with certain data type? #2248
-
|
I want to add some attribute to generated data types, except for data types who has e.g. pub struct SelectObjectContentOutput {
/// <p>The array of results.</p>
pub payload: aws_smithy_http::event_stream::Receiver<
crate::model::SelectObjectContentEventStream,
crate::error::SelectObjectContentEventStreamError,
>,
}Should I just check it by iterating through PR: #2183 |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 24 replies
-
|
You can use this So perhaps something like: // If none of the members are event stream
if (structShape.members.none { it.isEventStream(model) }) {
// add ser/de attributes
} |
Beta Was this translation helpful? Give feedback.
-
|
That's really weird. I don't see anything there that should NPE either. Try doing a full clean: |
Beta Was this translation helpful? Give feedback.
-
|
I actually did it few times but didn't really help. Let me try it again. |
Beta Was this translation helpful? Give feedback.
-
|
FYI I tried on github codespace and I got this error. |
Beta Was this translation helpful? Give feedback.
-
|
This is from the CI |
Beta Was this translation helpful? Give feedback.
-
|
@Velfi |
Beta Was this translation helpful? Give feedback.
-
|
Hi, we're still looking into it. I wanted to make sure the Null pointer exception was reproducible in |
Beta Was this translation helpful? Give feedback.
-
|
I really appreciate your help! I'm suspecting that it's something to do with class Attribute(val inner: Writable) {
...
Attribute(cfgAttr(all(writable("aws_sdk_unstable"), pair("feature" to "serde-serialize"), derive(RuntimeType.SerdeSerialize)))).render(writer)
Attribute(cfgAttr(all(writable("aws_sdk_unstable"), pair("feature" to "serde-deserialize"), derive(RuntimeType.SerdeDeserialize)))).render(writer)Not quite sure how to fix it though |
Beta Was this translation helpful? Give feedback.
-
|
I was able to fix the NPE by replacing However, it seems that |
Beta Was this translation helpful? Give feedback.
-
|
Let me push the new one. |
Beta Was this translation helpful? Give feedback.
-
|
Let me share two things: 1. where NPE is coming from and 2. how you could debug code as
Up in the call stack, we see Further up in the call stack, we see it originate from rendering If we go up even further (not showing a screenshot), we see that all the frames above are part of rendering
You can then set an Exception Breakpoint as follows so the bugger stops only when NullPointerException is encountered: With that setting, you can start the debugger in IntelliJ with the bug icon. Then in a terminal, you can execute the following from the root directory of the (you may need to run You should be able to reproduce the first screenshot in this reply. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the help. Let me look into it. |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to make it work on windows? I get this error which I think is coming from my OS. (FYI, I usually use docker) |
Beta Was this translation helpful? Give feedback.
-
|
Hmm, I tried mine on mac but didn't run it on Windows. As far as I know, there are two ways around it. The first is to make sure that special characters in JSON strings in |
Beta Was this translation helpful? Give feedback.
-
|
I replaced this class Attribute(val inner: Writable) {
...
Attribute(cfgAttr(all(writable("aws_sdk_unstable"), pair("feature" to "serde-serialize"), derive(RuntimeType.SerdeSerialize)))).render(writer)
Attribute(cfgAttr(all(writable("aws_sdk_unstable"), pair("feature" to "serde-deserialize"), derive(RuntimeType.SerdeDeserialize)))).render(writer)with this class Attribute(val inner: Writable) {
constructor(str: String) : this(writable(str))
constructor(runtimeType: RuntimeType) : this(runtimeType.writable)
val SerdeSerialize = Attribute(RuntimeType.SerdeSerialize)
val SerdeDeserialize = Attribute(RuntimeType.SerdeDeserialize)Since constructor accepts This is the new error that I've got. |
Beta Was this translation helpful? Give feedback.
-
|
Any idea? |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I've made changes as suggested on top of It's still an NPE in disguise, although the stack trace you got did not explicitly say that:
Any chance |
Beta Was this translation helpful? Give feedback.
-
|
I decided to print every argument that derive received and I got this. fun derive(vararg runtimeTypes: RuntimeType): Writable = {
// Empty derives are meaningless
if (runtimeTypes.isNotEmpty()) {
// Sorted derives look nicer than unsorted, and it makes test output easier to predict
println("==============")
for (i in runtimeTypes) {
println(i)
println(i == null)
}
println("==============")
val writables = runtimeTypes.sortedBy { it.path }.map { it.writable }.join(", ")
rustInline("derive(#W)", writables)
}
}So you are right. Not quite sure why this is happening though. |
Beta Was this translation helpful? Give feedback.
-
|
I think this could be something to do with kotlin itself tbh. |
Beta Was this translation helpful? Give feedback.
-
|
I tried calling this and it caused a stack over flow. rustInline("#W", Attribute.SerdeSerialize.inner)
rustInline("#W", Attribute.SerdeDeserialize.inner) |
Beta Was this translation helpful? Give feedback.
-
|
At this point, it's probably easier to work with a test whose scope is narrower than The test fails with a NPE with the same root cause ( There could be other unit tests that fail in the same way. FYI, I use IntelliJ to run & debug unit tests. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the tip. I switched over to intellij. It's lot faster than VSC! Doesn't work in some cases but unit test works just fine so I think I will stick with it. I tried this code and it works just fine. @Test
fun `serde attribute works properly`() {
val writer = RustWriter.root()
Attribute.SerdeDeserialize.render(writer)
println(writer)
}
I wonder what's causing the whole issue. |
Beta Was this translation helpful? Give feedback.
-
|
I tried it with |
Beta Was this translation helpful? Give feedback.
-
|
This for some reason worked: class Attribute(val inner: Writable) {
public fun SerdeSerialize(): Attribute {
return Attribute(cfgAttr(all(writable("aws_sdk_unstable"), feature("serde-serialize")), derive(RuntimeType.SerdeSerialize)))
}
public fun SerdeDeserialize(): Attribute {
return Attribute(cfgAttr(all(writable("aws_sdk_unstable"), feature("serde-deserialize")), derive(RuntimeType.SerdeDeserialize)))
}public object RenderSerdeAttribute {
public fun writeAttributes(writer: RustWriter) {
Attribute("").SerdeSerialize().render(writer)
Attribute("").SerdeDeserialize().render(writer)
} |
Beta Was this translation helpful? Give feedback.
-
|
but this doesn't work. val SerdeSerialize = Attribute(cfgAttr(all(writable("aws_sdk_unstable"), feature("serde-serialize")), derive(RuntimeType.Serde.resolve("Serialize"))))
val SerdeDeserialize = Attribute(cfgAttr(all(writable("aws_sdk_unstable"), feature("serde-deserialize")), derive(RuntimeType.Serde.resolve("Deserialize")))) |
Beta Was this translation helpful? Give feedback.
-
|
#2248 (reply in thread) |
Beta Was this translation helpful? Give feedback.
You can use this
MemberShape.isEventStreamfunction to determine if the member of aStructureShapeis an event stream type (@streaming union).So perhaps something like: