changed a webp file of logo #375
Conversation
There was a problem hiding this comment.
Hello,
First off, thanks for the contribution on behalf of the SLIIT FOSS community.
Sadly however both themes seem to break with this fix
- Dark mode - Missing transparency in the logo background
- Dark mode - Background purple and navbar purple are two different color codes
- Light mode - Background should be the original dark gray color
|
Ok I will keep that changes and i will done it in few hours. I want to do
this so you can assign it to me?
…On Sun 23 Oct, 2022, 6:25 PM Akalanka Perera, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hello,
First off, thanks for the contribution on behalf of the SLIIT FOSS
community.
Sadly however both themes seem to break with this fix
- Dark mode - Missing transparency in the logo background
- Dark mode - Background purple and navbar purple are two different
color codes
- Light mode - Background should be the original dark gray color
[image: image]
<https://user-images.githubusercontent.com/73662613/197393177-1ea21f4d-9b98-4581-a7dd-1a249e93c46b.png>
[image: image]
<https://user-images.githubusercontent.com/73662613/197393283-cc364569-5eee-4746-a5d0-d3f06940c1c2.png>
[image: image]
<https://user-images.githubusercontent.com/73662613/197393291-40bc8294-af86-4e12-81f7-c762e7816827.png>
[image: image]
<https://user-images.githubusercontent.com/73662613/197393298-7e736adb-9cbd-4dbd-a9c5-0db6b034d831.png>
—
Reply to this email directly, view it on GitHub
<#375 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV7ZR5FMCRJBIBHPQAWZMQTWEUYU7ANCNFSM6AAAAAARMHM3ZY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sure😄 |
|
@Akalanka47000 Do you want your logo to be different in dark and light mode? because in this website navbar color and body color are totally different so pls clarify it. |
Sorry for the late reply, in the dark mode the logo background should be the same color as the background color of the navbar and in the light mode it should be the same dark gray color as it was in the original logo |
|
Further there seems to be an outline which has been left during the background removal process😟 |
|
I've updated the format of the .env file as well required for running the project without which you might be stuck. The file is at the root of the project name .env.test. Apologies for the inconvenience. |
https://github.com/sliit-foss/sliitfoss/issues/372