Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skywire cli subcommand + api to disable dmsg connection at runtime (for testing) #1792

Open
0pcom opened this issue Mar 26, 2024 · 1 comment
Labels
dmsg issue of dmsg client, connection, or dmsghttp-config testing implement for testing purposes

Comments

@0pcom
Copy link
Collaborator

0pcom commented Mar 26, 2024

In order to test the service which will restart the visor on loss of connection to dmsg, it's necessary to be able to explicitly disable the dmsghttp logserver as the /health endpoint is the one which will be checked by the service.

If not like that, then it must be possible by some other means to break the connection to dmsg in order to test this service or a future fix in the codebase reconnect logic.

I think it will not work to disable the connection to dmsg at startup as the visor requires this to even start correctly. But if possible to disable dmsg during runtime via skywire cli subcommand and RPC / API; that will work. as well as disabling the logserver.

The systemd service which checks if the visor is connected to dmsg will use dmsgcurl

dmsgcurl currently does not work with dmsghttp-config.json and will not be useful for chinese users (and will likely restart the visor inappropriately) until that is implemented.

@0pcom
Copy link
Collaborator Author

0pcom commented Apr 9, 2024

as noted in #1804 the dmsghttp log server may become inaccessible even though the visor apparently maintains a connection to dmsg.

@0pcom 0pcom changed the title skywire visor flag to disable dmsghttp log server - OR - skywire cli flag to disable dmsg connection at runtime ~~skywire visor flag to disable dmsghttp log server - OR -~~ skywire cli flag to disable dmsg connection at runtime May 17, 2024
@0pcom 0pcom changed the title ~~skywire visor flag to disable dmsghttp log server - OR -~~ skywire cli flag to disable dmsg connection at runtime skywire cli subcommand + api to disable dmsg connection at runtime (for testing) May 17, 2024
@0pcom 0pcom added dmsg issue of dmsg client, connection, or dmsghttp-config testing implement for testing purposes labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dmsg issue of dmsg client, connection, or dmsghttp-config testing implement for testing purposes
Projects
None yet
Development

No branches or pull requests

1 participant