Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmsgtracker-client ensure that the visor stays connected to dmsg #1786

Open
0pcom opened this issue Mar 21, 2024 · 0 comments
Open

dmsgtracker-client ensure that the visor stays connected to dmsg #1786

0pcom opened this issue Mar 21, 2024 · 0 comments
Labels
breaking issue breaks critical functionality dmsg issue of dmsg client, connection, or dmsghttp-config enhancement New feature or request
Milestone

Comments

@0pcom
Copy link
Collaborator

0pcom commented Mar 21, 2024

The dmsgtracker client should be used more effectively and in the context of ensuring that the visor reconnects to dmsg if / when it becomes disconnected.

Currently the dmsgtracker-client is only started when running the hypervisor. Perhaps it should start by default regardless of hypervisor interface being served.

As a temporary measure to ensure the visor will be restarted if it loses it's connection to dmsg, a service will be included in the linux packages which checks if the /health of the locally running visor can be fetched over dmsghttp with dmsgcurl by the visor's public key. If it cannot be fetched after a few attempts, this will trigger the visor to be restarted

This can be more effectively and sensibly implemented in the source code itself. At which time this is implemented, the service can be removed from the packages.

#1756 describes a situation where the dmsgtracker client is actually needed for `skywire-cli visor info

@0pcom 0pcom added enhancement New feature or request dmsg issue of dmsg client, connection, or dmsghttp-config breaking issue breaks critical functionality labels Mar 21, 2024
@0pcom 0pcom pinned this issue Mar 23, 2024
@0pcom 0pcom added this to the v1.4.0 milestone Mar 23, 2024
@0pcom 0pcom unpinned this issue Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking issue breaks critical functionality dmsg issue of dmsg client, connection, or dmsghttp-config enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant