Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent flag format for apps config #1707

Closed
0pcom opened this issue Dec 22, 2023 · 1 comment
Closed

inconsistent flag format for apps config #1707

0pcom opened this issue Dec 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@0pcom
Copy link
Collaborator

0pcom commented Dec 22, 2023

It appears that we use flags inconsistently (in some cases incorrectly) for the apps, currently.

I'm not sure why we haven't noticed errors from this yet.

The way the code is currently on develop, the apps use the "flags" package, which accepts flags in the format -flag and not --flag

here it's in the single hyphen format
https://github.com/skycoin/skywire/blob/develop/pkg/visor/visorconfig/config.go#L247

but in pkg/visor/api we use the double hyphen format in some places and single hyphen in other places
https://github.com/skycoin/skywire/blob/develop/pkg/visor/api.go#L777
https://github.com/skycoin/skywire/blob/develop/pkg/visor/api.go#L797

#1704 addresses this

@0pcom 0pcom added the bug Something isn't working label Dec 22, 2023
@mrpalide mrpalide added this to the v1.3.18 milestone Feb 7, 2024
@0pcom
Copy link
Collaborator Author

0pcom commented Mar 5, 2024

fixed in #1704

@0pcom 0pcom closed this as completed Mar 5, 2024
@mrpalide mrpalide removed this from the v1.3.20 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants