Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open sourcing things #95

Open
8 of 9 tasks
aecay opened this issue Nov 12, 2019 · 3 comments
Open
8 of 9 tasks

open sourcing things #95

aecay opened this issue Nov 12, 2019 · 3 comments

Comments

@aecay
Copy link
Collaborator

aecay commented Nov 12, 2019

  • in CONTRIBUTING.md: With Toolkit being an open source project might be worth searching for all instances of Toolkit
  • are you going to be able to response within 2 days to issues on Github? is that reasonable?
  • I can't see any environmental requirements in README.md or DEV.md, does this mean there is no minimum python version or any other needs?
  • On the project tab it references [an IP adddress] , probably not wise to expose an internal ip address to the public.
  • I'd recommend creating 1 wiki page if only to signpost people to the right markdown doc.
  • Do you want to enable the dependency graph?
  • Worth enabling the security alerts so we can show that we take it seriously at Sky and stay up to date with dependencies?
  • Quite a few open issues, many of them go back several months, worth a tidy up first?
  • I'd consider creating a PR template as that makes things easier to contribute.
@aecay
Copy link
Collaborator Author

aecay commented Nov 12, 2019

@jb098 you are the repo admin so you are the only one who can enable the dependency graph and sec alerts (if warranted). You're also the only one who can easily create the PR template through the Github UI (I think there's a way to do it by creating yaml files in the repo, but it sounds like a pain compared to using the UI)

@jb098
Copy link
Collaborator

jb098 commented Nov 12, 2019

@jb098 you are the repo admin so you are the only one who can enable the dependency graph and sec alerts (if warranted). You're also the only one who can easily create the PR template through the Github UI (I think there's a way to do it by creating yaml files in the repo, but it sounds like a pain compared to using the UI)

@aecay I've added admin rights for you, Davide already had them. That's not to say I won't do the above tasks but now at least everyone has the option.

@jb098
Copy link
Collaborator

jb098 commented Nov 12, 2019

Added in badges to the repo and merged all other docs. Last outstanding thing is to cleanup stale issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants