I'm working on a project that is using nodejs-websocket
I'm about to need to add a Web Socket API on the same server / port than an existing REST-like HTTP API

This ticket has been closed without comment
Does it means:

• it will never be implemented (this way or another) ?
• it is already implemented (didn't saw it in the doc) ?
• it is on going through another ticket (which one) ?

Maybe there is another approach available, like:

• 1st creating the WebSocket Server
• then getting access to its inner http server and bind row HTTP request listeners to it.

Thanks,

Regards

Looks like similar requirement was raised in #3

From the answer on that ticket, one of the limitation would be that this module is directly bound to the tls.Server or net.Server socket level without the http layer

So...
I looked a bit...

• the node.js http.Server inherits from net.Server
• the node.js https.Server inherits from tls.Server

Which means that when the nodejs-websocket server is created via createServer() it could accept an already existing http or https server socket, instead of creating a new one, if one if provided as option. Calling instanceof tls.TLSSocket/net.Socket could even work for a more generic usage.

var http = require("http")
var ws = require("nodejs-websocket")

var wsServer;
var httpServer = http.createServer();

httpServer.on('upgrade', function (req, socket, head) {
    wsServer = ws.createServer({ socket: socket, upgradeHead: head }, function (conn) {
    	conn.on("text", function (str) {
	    	conn.sendText(str.toUpperCase()+"!!!")
    	})
	    conn.on("close", function (code, reason) {
		    console.log("Connection closed")
    	})
    });
});

httpServer.listen(8001);

It may worth a try

Updated to allow handling upgrade http handshake

Didn't tested but the implementation could look like

	var socket = options.socket;
	if (socket && (socket instanceof tls.TLSSocket || socket instanceof net.Socket)) {
		this.socket = options.socket
	} else if (secure) {
		this.socket = tls.createServer(options, onConnection)
	} else {
		this.socket = net.createServer(options, onConnection)
	}

Plus some code to handle the upgrade handshake

I tried to implement it
I'm almost there

Still an initial message to catch

looks good.

I've implemented in #66, you can try to use it and check if everything works well