Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing of receive window calculations missing 4.25 #124

Open
JacoTuks opened this issue Jun 9, 2022 · 0 comments
Open

Closing of receive window calculations missing 4.25 #124

JacoTuks opened this issue Jun 9, 2022 · 0 comments

Comments

@JacoTuks
Copy link

JacoTuks commented Jun 9, 2022

Expected Behavior

According to The LoRa Modem Designer's guide, the duration of a preamble is (nPreamble + 4.25)*Tsym but in class-a-end-device-lorawan-mac.cc the +4.25 is omitted.

image

Actual Behavior

Both receive windows are scheduled to close too fast.

Code in question

class-a-end-device-lorawan-mac.cc

  1. m_closeFirstWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseFirstReceiveWindow, this); //m_receiveWindowDuration

  2. m_closeSecondWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseSecondReceiveWindow, this);

Specifications

  • lorawan module version: develop branch latest commit (e8f7a21)

Please let me know if I have missed something? I will happily create a pull request if you agree that this is an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant