Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the check command view #726

Open
mohierf opened this issue Dec 19, 2019 · 7 comments
Open

Improve the check command view #726

mohierf opened this issue Dec 19, 2019 · 7 comments
Labels

Comments

@mohierf
Copy link
Contributor

mohierf commented Dec 19, 2019

On the host/service view, the check command is simply rendered as the check command name. There is no information about the arguments and about the real command that is executed after the macro expansion.

This may be improved like this:
image

mohierf added a commit to mohierf/mod-webui that referenced this issue Dec 19, 2019
@mohierf
Copy link
Contributor Author

mohierf commented Dec 19, 2019

@maethor : if you wish to backport, you can cherry-pick this commit: mohierf@ddf162a

@mohierf
Copy link
Contributor Author

mohierf commented Dec 19, 2019

This rendering is not really perfect because it would be better to display the real executed command. At the moment, in the example, the check_mongodb command is not expanded before the macro expansion. To be completed...

@mohierf
Copy link
Contributor Author

mohierf commented Dec 19, 2019

Something like this content looks more useful:
image

The real executed command and its macro expansion 👍

Not yet perfect because some macros are not expanded ... but it looks better. Work in progress...

mohierf added a commit to mohierf/mod-webui that referenced this issue Dec 21, 2019
mohierf added a commit to mohierf/mod-webui that referenced this issue Dec 22, 2019
@mohierf
Copy link
Contributor Author

mohierf commented Dec 22, 2019

The most recent commit I pushed is a squash of 3 commits I did to test and improve the macro expansion in the commands. The final result is:
image

@maethor
Copy link
Contributor

maethor commented Jan 3, 2020

Nice idea. I will have a look.

@mohierf
Copy link
Contributor Author

mohierf commented Jan 4, 2020

Indeed, on my own fork, the integ branch is up-to-date with many modifications and I tested as much as I could with Alignak AND Shinken (thanks to docker) ... you should give a try and we could merge in the main repo ?

@maethor
Copy link
Contributor

maethor commented Jan 26, 2020

Would you be able to make PR ? I prefer to avoid cherry picking. In this issue for instance, I don't know if the commit you are talking about in the second message is covering the modifications you are talking about in the forth and fifth messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants