MSH Version ID set to return type string when it can be an array.

[securit]

At

HL7/src/HL7/Segments/MSH.php

Line 296 in f31ff81

public function getVersionId(int $position = 12): string

on #92 you have changed the getVersionId to have a return type of string, but in HL7v2.7 and later this field is an array.

https://hl7-definition.caristix.com/v2/HL7v2.7/DataTypes/VID
https://hl7-definition.caristix.com/v2/HL7v2.7.1/DataTypes/VID
https://hl7-definition.caristix.com/v2/HL7v2.8/DataTypes/VID

For maximum compatibility I suggest that you change this to:

public function getVersionId(int $position = 12): string|array

[senaranya]

Thanks for raising this issue. Can you please share a sample MSH for me to use in tests?

[securit]

This should do:

MSH|^~\&|Sending App|sendEDI|Receiving App|receiveEDI|20221213152007|PKI|REF^I12^REF_I12|GenericNZ2.4REF|P|2.4^NZL^1.0

[senaranya]

Do take a look - #111

[senaranya]

Resolved in #111