Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

AddCommand: On success, should not update filtered list to show all #650

Open
Zhiyuan-Amos opened this issue Aug 31, 2017 · 2 comments
Open

Comments

@Zhiyuan-Amos
Copy link
Contributor

AddCommand should not update Model's filtered list to show all. Rather, it should show the current filtered list + the added person.

@damithc
Copy link
Contributor

damithc commented Sep 1, 2017

Rather, it should show the current filtered list + the added person.

We should not add the new person to the filtered list if the new person does not match the filter cirteria though.

On second thoughts, perhaps the current behavior is not that bad. In some cases the user may no longer be interested in the previous filtered list. If he is, he can use the 'up' button to run the previous find command.

Something I would like to do though is to be able to highlight the person that was just edited/added/deleted, for a few seconds. I think that too might require a change to the model architecture, possibly requiring another 'view model' layer. The filtered list too should be part of that layer. The current model should be reserved for keeping the 'one source of truth' that we save to the storage.

@Zhiyuan-Amos
Copy link
Contributor Author

Zhiyuan-Amos commented Sep 1, 2017

In some cases the user may no longer be interested in the previous filtered list.

I guess it's a bit hard to argue for the use case because we don't really have a user base to find out which behavior they prefer :P

Something I would like to do though is to be able to highlight the person that was just edited/added/deleted, for a few seconds. I think that too might require a change to the model architecture, possibly requiring another 'view model' layer.

Will label this as epic then :P

@Zhiyuan-Amos Zhiyuan-Amos added the c.Project Project (may or may not consist of a research component). label Sep 1, 2017
@pyokagan pyokagan removed the c.Project Project (may or may not consist of a research component). label Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants