Remove unnecessary semi-colon #347 #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
v1@dezhanglee submitted v1 for review.
Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level2.git refs/pr/512/1/head:BRANCHNAMEwhere |
|
@dezhanglee You might want to check out the contributor's guide section on commit messages. You can look through previously merged PRs for examples. |
|
hi @j-lum , is my commit message ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347
This PR removes a redundant ; from the Command class.