Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Check' suffix for module names in checkstyle.xml #147

Open
yamgent opened this issue Jan 31, 2017 · 1 comment
Open

Remove 'Check' suffix for module names in checkstyle.xml #147

yamgent opened this issue Jan 31, 2017 · 1 comment

Comments

@yamgent
Copy link
Member

yamgent commented Jan 31, 2017

Prerequisite: se-edu/addressbook-level4#279 (further study about changes in checkstyle.xml is required)

Some module names in checkstyle.xml have the Check suffix. For example, <module name="TypeNameCheck">.

We should change them to be <module name="TypeName">, as the Check suffix is not needed for checkstyle to work. The module name would also be more concise if the suffix is removed.

Reference: http://stackoverflow.com/questions/41931046/checkstyle-module-name-constantname-vs-constantnamecheck

@damithc
Copy link
Contributor

damithc commented Jan 31, 2017

@yamgent You may want to link to the ongoing PR at level-4 as this issue needs to wait until that PR is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants