Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Scribe key press when selecting a word #141

Closed
2 tasks done
andrewtavis opened this issue Mar 1, 2022 · 3 comments
Closed
2 tasks done

Rework Scribe key press when selecting a word #141

andrewtavis opened this issue Mar 1, 2022 · 3 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Many have commented recently that the functionality of the Scribe key when a word is selected could be reworked to present the commands and then run them over the selected word. What this means is that the command prompts would not be shown and instead the selected word would directly have the command ran over it. This would replace the current functionality where for nouns and pronouns have their form and coinciding case shown respectively.

A way to include the current functionality would be to include it as a selectable option instead of commands that aren't applicable. Specifically words that are already in the keyboard's target language would not need to be translated, so this command could be replaced. Commands that could be displayed given the type of word selected include:

Nouns: form, plural
Verbs: conjugate (and case once #81 is finished)
Prepositions: case

This feature could also later present the Synonym command when #20 has been finished. A Definition command could be included as well, with maybe the information from Form and Case being included so that only three options would be needed.

Contribution

I need to get more feedback on this, but will implement it if it makes sense. Help would be appreciated if people have interest!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed -priority- High priority good first issue Good for newcomers and removed -priority- High priority good first issue Good for newcomers labels Mar 1, 2022
@andrewtavis
Copy link
Member Author

andrewtavis commented Oct 14, 2022

Something that could also be done for this is that the command options could be shown along with the annotation. The annotation could be shown over the translate button field if there is one, and aside from that the conjugate button and plural button could be shown. It doesn't seem reasonable that a person would want to do an autosuggestion at this time, so we could present the two other buttons with it and use the selected word as a source of the command when it's pressed. This would actually be quite simple to implement! 😊

The annotation could also be replaced with an information button that wouldn't be user intractable at first, or this could be shown in cases when there is no annotation.

@Jag-Marcel
Copy link
Member

Working on this one ✋

@andrewtavis
Copy link
Member Author

Closed by #485 :) Thanks so much for the great work here, @Jag-Marcel! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants