Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client robustness to simple messages #127

Open
1 task
cnweaver opened this issue Mar 2, 2021 · 0 comments
Open
1 task

Improve client robustness to simple messages #127

cnweaver opened this issue Mar 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@cnweaver
Copy link
Contributor

cnweaver commented Mar 2, 2021

Description

As a user, I do not want the client to abort if it finds any message without an envelope (without even letting me see the offending message).

Currently, the client demands that all messages have a JSON envelope with a "format" field specifying the data format and a "content" field contain the actual data. This is fine, but since we give users direct access to Kafka, it only takes one person writing a message (with kafkacat or any other tool which does not enforce the hop client's notions of formatting) which does not conform to this to make the client perpetually unhappy, potentially making it impossible for users to read the any subsequent messages in the affected topic if their start point for reading includes the 'bad' message.

Definition of Done

The hop client should make it possible to do some combination of the following:

  • continue reading even after encountering an unintelligible message
  • work with JSON messages which are not otherwise wrapped
  • display offending messages which do not meet formatting expectations

Tasks/Items:

  • TBD
@cnweaver cnweaver added the enhancement New feature or request label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant