Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross_val_predict for stacked estimators #27

Open
skylarbpayne opened this issue Mar 31, 2023 · 1 comment
Open

Support cross_val_predict for stacked estimators #27

skylarbpayne opened this issue Mar 31, 2023 · 1 comment

Comments

@skylarbpayne
Copy link

First -- this library looks great, pretty much exactly what I was looking for!

It appears though, that each dependent estimator is trained on the entire passed dataset directly. This can lead to overfitting. Instead, it would be nice if cross_val_predict was supported in some fashion so when we have estimators A -> B, B is trained on output of cross_val_predict rather than raw predict output.

Given activity in this repo, I'm assuming its basically inactive. But if not, I'd be happy to contribute such functionality.

@big-o
Copy link
Collaborator

big-o commented May 26, 2023

Hi and thanks for the feedback! The project is very much active, although I'm running it alone in my spare time so may be sporadic and slow to reply - apologies for that.

I would have expected the sklearn cross_val* functions to work since the DAG should respect the estimator API, so if it doesn't then this sounds like a bug.

If you're interested in contributing a PR that would be very welcome and I'd be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants