Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert predefined metric into a PairsClassifierMixin #169

Open
bellet opened this issue Feb 14, 2019 · 0 comments
Open

Convert predefined metric into a PairsClassifierMixin #169

bellet opened this issue Feb 14, 2019 · 0 comments
Milestone

Comments

@bellet
Copy link
Member

bellet commented Feb 14, 2019

A typically use case of metric learning is to use the learned metric to predict whether two examples match or not (as in facial verification applications). This can be the case even though the metric has not been learned from pairwise supervision (positive/negative pairs) but from quadruplet or even fully supervised (e.g., LMNN).

Therefore it would potentially be useful to give a simple way for users to do that for metric learners that are not PairsClassifierMixin.

I see two possible options:

  • add a predict_pairs method and copy the methods to set/calibrate the decision threshold from PairsClassifierMixin introduced in [MRG+1] Threshold for pairs learners #168
    drawback: not compatible with sklearn which expects predict
  • add a new instance of PairsClassifierMixin which takes as input a predefined metric instead of fitting on data, see point 3/ in [MRG+1] Threshold for pairs learners #168 (review)
    drawback: user needs to instantiate a new object after fitting the metric
@bellet bellet added this to the v0.6.0 milestone Feb 14, 2019
@bellet bellet modified the milestones: v0.6.0, v0.7.0 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant