-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
**fit_params and **predict_params #212
Comments
Hey @cerlymarco, thank you! Indeed, this could be added. Could you give us a use case for this issue? Additionally, note that in the .fit() of |
Hi @LacombeLouis, thanks for the response. The most effective and simple application may be using LGBMRegressor/LGBMClassifier or XGBRegressor/Classifier. Both of them allow the usage of lot parameters in fit and predict... Not only... all the tools which provide custom sckiti-learn estimators should benefit from this. In |
Hi @cerlymarco, thank you for the suggestion. Indeed, this makes a lot of sense. For the moment, we are quite busy with other projects or more documentation of methods. If you have time and would like to contribute, we would be delighted to guide you through this process (note that you can start by following the guidelines). |
Hello @LacombeLouis @thibaultcordier @cerlymarco, I have opened the PR #391 for adding the possibility of passing fit parameters. |
Why not allow the usage of fit_params and predict_params of the estimator in .fit(...) and .predict(...)?
Is there a special reason behind this choice?
The implementation of this should be straightforward!
The text was updated successfully, but these errors were encountered: