Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**fit_params and **predict_params #212

Open
cerlymarco opened this issue Jul 24, 2022 · 5 comments
Open

**fit_params and **predict_params #212

cerlymarco opened this issue Jul 24, 2022 · 5 comments
Assignees
Labels
Enhancement Type: enhancement (new feature or request) Good first issue Easy issue to start to contribute to MAPIE Source: contributors Proposed by contributors.
Milestone

Comments

@cerlymarco
Copy link

Why not allow the usage of fit_params and predict_params of the estimator in .fit(...) and .predict(...)?
Is there a special reason behind this choice?

The implementation of this should be straightforward!

@cerlymarco cerlymarco added the Enhancement Type: enhancement (new feature or request) label Jul 24, 2022
@LacombeLouis
Copy link
Collaborator

Hey @cerlymarco, thank you! Indeed, this could be added. Could you give us a use case for this issue? Additionally, note that in the .fit() of MapieRegressor does both fitting and predicting (as it predicts on the calibration set in the .fit() method).

@cerlymarco
Copy link
Author

Hi @LacombeLouis, thanks for the response.

The most effective and simple application may be using LGBMRegressor/LGBMClassifier or XGBRegressor/Classifier.

Both of them allow the usage of lot parameters in fit and predict...

Not only... all the tools which provide custom sckiti-learn estimators should benefit from this.

In MapieRegressor(...).fit() predicting should not involve the usage of predict_params but only fit_params. This is a reasonable simplification which is also adopted in cross_val_predict from sklearn

@cerlymarco cerlymarco reopened this Aug 2, 2022
@LacombeLouis
Copy link
Collaborator

Hi @cerlymarco, thank you for the suggestion. Indeed, this makes a lot of sense. For the moment, we are quite busy with other projects or more documentation of methods. If you have time and would like to contribute, we would be delighted to guide you through this process (note that you can start by following the guidelines).

@LacombeLouis LacombeLouis added the Good first issue Easy issue to start to contribute to MAPIE label Dec 1, 2022
@thibaultcordier thibaultcordier added the Source: contributors Proposed by contributors. label Jul 4, 2023
@sami-ka sami-ka mentioned this issue Dec 28, 2023
9 tasks
@sami-ka
Copy link
Contributor

sami-ka commented Dec 29, 2023

Hello @LacombeLouis @thibaultcordier @cerlymarco, I have opened the PR #391 for adding the possibility of passing fit parameters.
Feel free to give any feedback!

@BaptisteCalot
Copy link
Collaborator

The addition of **fit_params has been done. I have created two issues to separately address the addition of **predict_params: for regression, issue #492 , and for classification, issue #491 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Type: enhancement (new feature or request) Good first issue Easy issue to start to contribute to MAPIE Source: contributors Proposed by contributors.
Projects
None yet
Development

No branches or pull requests

5 participants