Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-268 - Create a presenter for automated submission for WGS branch on Adp Lig plate #4290

Open
3 tasks
Tracked by #4199 ...
yoldas opened this issue Aug 19, 2024 · 3 comments · May be fixed by sanger/limber#1982
Open
3 tasks
Tracked by #4199 ...
Assignees
Labels
EMSeq emSEQ On Hold On hold

Comments

@yoldas
Copy link
Member

yoldas commented Aug 19, 2024

User story
As PSD, we would like to create a presenter to do an automated submission for WGS branch on Adp Lig plate when the plate is in passed state. The first plate of the WGS branch is DNA Lib PCR plate, converted from tag plate. The presenter should co-exist or include the behaviour of the permissive presenter on the Adp Lig plate that pre-creates the LCMT EM ox plate.

Who are the primary contacts for this story
Abdullah (PSD)
Andrew (PSD)
Katy (PSD)
Shiv (PSD)
Scott G (R&D)
Sara W (Lab ops)

Who is the nominated tester for UAT
TBC

Acceptance criteria
To be considered successful the solution must allow:

  • Automated submission button should be available only when Adp Lig plate is passed
  • Clicking the button should do an automated submission on the Adp Lig plate for the WGS branch.
  • Once the submission is done, it should allow the creation of the first plate of the branch, DNA Lib PCR.

Dependencies
This story is blocked by the following dependencies:

References

Additional context
We need a request filtering for the branch when transferring from Adp Lig to DNA Lib PCR. This can be done in pipeline config or we will need a separate labware creator.

@psd-issuer psd-issuer bot changed the title Create a presenter for automated submission for WGS branch on Adp Lig plate Y24-268 - Create a presenter for automated submission for WGS branch on Adp Lig plate Aug 19, 2024
@yoldas yoldas added the EMSeq emSEQ label Aug 19, 2024
@SHIV5T3R SHIV5T3R self-assigned this Aug 29, 2024
@SHIV5T3R SHIV5T3R assigned SHIV5T3R and yoldas and unassigned SHIV5T3R and yoldas Sep 9, 2024
@StephenHulme StephenHulme self-assigned this Sep 20, 2024
@StephenHulme
Copy link
Contributor

Integration Suite MR

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Oct 15, 2024

Notes / questions from group review:

  • If manual transfer on a downstream permissively created plate when parent is still pending, what happens - have you broken the pipeline?
  • If fail wells on upstream plate, what happens to permissively created downstream plates?
  • Does it allow you to fail wells on a downstream permissively created plate?
  • Can’t fail wells on the ADP Lig plate - because input?
  • Display type of submission in panel.
  • We should restrict submission button to only display if there’s not already an active submission of configured type

We though the final one was the only one to fit within the scope of this story.

@StephenHulme StephenHulme added the On Hold On hold label Oct 21, 2024
@StephenHulme
Copy link
Contributor

On hold - pending outcome of submissions discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment