Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-007 Updates to PBMC donor pooling - create plate #1611

Open
2 of 4 tasks
yoldas opened this issue Mar 4, 2024 · 4 comments · May be fixed by #1734
Open
2 of 4 tasks

Y24-007 Updates to PBMC donor pooling - create plate #1611

yoldas opened this issue Mar 4, 2024 · 4 comments · May be fixed by #1734

Comments

@yoldas
Copy link
Member

yoldas commented Mar 4, 2024

User story
As a user of the scRNA Core pipeline, I would like updates to the PBMC Donor pooling to support GEM-X chip.

Who are the primary contacts for this story
Katy, Lesley, Abby

Who is the nominated tester for UAT
Lesley, Abby

Acceptance criteria
To be considered successful the solution must allow:

  • Replace the lookup table for the number of source samples according to the chip type decided. Currently, this table (copy of Cardinal's) is used for 1-96 samples and a default number (16) for the number of pools is assumed for more samples.
  • Add the constraint around the collection sites, as with Cardinal (if any) to donor pooling. At the time of writing this story, the requirement is not specified.
  • Update pooling algorithm for an even distribution of samples across pools. For example, for 32 samples with same study and project, and unique donors, it generates 3 pools as expected but the sizes are 8, 8, and 16. It is because of the halving of the biggest pools for distribution done by the algorithm. They should be 11, 11, and 10 instead. Only the distribute_groups_across_pools method needs changing.
  • Consider removing the pooling config file (look up table; Interim scRNA Core pooling config). A pooling strategy based on a suggested number of cells in a pool and a maximum may be better. For example, suggested size could be 10 and maximum could be 20.

Dependencies
This story is blocked by the following dependencies:

Additional context
Only one chip type is supported in this step. The lookup table to configure the number of pools based on the number of samples is affected by the decision of which chip to use and additional chip-specific considerations. We need to change code and configuration to use 10X Chromium 8-well GEM-X chip instead of 10X Chromium 16-well chip.

@KatyTaylor
Copy link
Contributor

Still on hold, awaiting discussion around pooling strategy in Thursday's working group.

@yoldas yoldas linked a pull request Jun 12, 2024 that will close this issue
@SujitDey2022
Copy link

@KatyTaylor @yoldas is this story still on hold?

@KatyTaylor
Copy link
Contributor

Yes, I believe so. We're still waiting to hear from R&D about it.

@KatyTaylor
Copy link
Contributor

Update from Abby last Friday (26th July) was that they have made some progress on this but still haven't finalised the strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants