Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include flow examples #36

Open
andreivladbrg opened this issue Sep 30, 2024 · 3 comments · May be fixed by #37
Open

Include flow examples #36

andreivladbrg opened this issue Sep 30, 2024 · 3 comments · May be fixed by #37
Assignees
@andreivladbrg
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Sep 30, 2024 •
edited
Loading

Changes

  • rename v2 dir to lockup
  • add flow dir
  • include examples for handling streams create pause adjust withdraw
  • include examples for calculations of the rps: e.g. X amount streamed in 3,6,12 months etc.
@andreivladbrg andreivladbrg self-assigned this Sep 30, 2024
@smol-ninja
Copy link
Member

Agree with all three except 1. Shouldn't we rename v2 to lockup after the next lockup release?

@andreivladbrg
Copy link
Member Author

Agree with all three except 1. Shouldn't we rename v2 to lockup after the next lockup release?

I think having v2 and flow would be even more confusing, as people might assume that flow is v3, which we don’t want. We’ve decided on package tethering and are moving away from this approach to making releases (v1,v2 etc). wdyt?

@smol-ninja
Copy link
Member

Good point about v2 and flow. It makes sense to go with lockup and flow now.

@andreivladbrg andreivladbrg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect. labels Oct 1, 2024
@andreivladbrg andreivladbrg linked a pull request Oct 2, 2024 that will close this issue
Open
@andreivladbrg andreivladbrg mentioned this issue Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: flow examples sablier-labs/examples
2 participants
@smol-ninja @andreivladbrg