refactor(error): improve error messages and file handling #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update error messages for file operations in the `LocalBackendErrorKind` enum. - Refactor the `ReadBackend` and `WriteBackend` implementations in the `LocalBackend` module to handle file opening errors more accurately. - Add error variants `OpeningFileForPartialReadingFailed` and `OpeningFileForWritingFailed` to provide specific information about file opening failures. - Create parent directory if it does not exist before opening the file for writing. Fixes #rustic-rs/rustic#1315 Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
simonsan
added
A-errors
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
|
I kept: for i in 0u8..=255 {
let filename = self.path.join("data").join(hex::encode([i]));
fs::create_dir_all(&filename).map_err(|err| {
LocalBackendErrorKind::DirectoryCreationFailed {
path: filename.clone(),
source: err,
}
})?;
}as that impacts compatibility with |
aawsome
requested changes
Oct 16, 2024
crates/backend/src/local.rs
Outdated
| fn write_bytes(&self, tpe: FileType, id: &Id, _cacheable: bool, buf: Bytes) -> Result<()> { | ||
| trace!("writing tpe: {:?}, id: {}", &tpe, &id); | ||
| let filename = self.path(tpe, id); | ||
|
|
||
| // create parent directory if it does not exist | ||
| if let Some(parent) = filename.parent() { |
There was a problem hiding this comment.
I would make a method parent_path and then just use self.parent_path(tpe,id) here.
There was a problem hiding this comment.
Added! Not sure how we would handle a non-existing parent? e.g. in a root path, that should never happen right? Or do you have another idea?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
simonsan
added
S-blocked
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge: will be rebased after #321 lands
LocalBackendErrorKindenum.ReadBackendandWriteBackendimplementations in theLocalBackendmodule to handle file opening errors more accurately.OpeningFileForPartialReadingFailedandOpeningFileForWritingFailedto provide specific information about file opening failures.Fixes rustic-rs/rustic#1315
Fixes #310