Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifications for ERC721 #326

Open
alex-chambet opened this issue Jul 20, 2020 · 0 comments
Open

Specifications for ERC721 #326

alex-chambet opened this issue Jul 20, 2020 · 0 comments

Comments

@alex-chambet
Copy link

I'm currently writing the specifications for ERC721 tokens. I've been able to specify: balanceOf, ownerOf, approve and getApproved. However, when trying to specify safeTransferFrom, I ran into issues and I'm now kinda stuck on them.

Specifically, I'm now focused on making safeTransferFrom works in the success cases (i'll do the failure afterwards). In the case where FROM_ID =/= TO_ID, everything works, but in the case where FROM_ID == TO_ID it does not work and I'm clueless about that.

Here is my gist of the specifications and the Solidity source code I used.

If someone can have a look and tell why it fails, it'll be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@alex-chambet and others