Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve clause ordering of requires and ensures when internalisig rules #4028

Closed
geo2a opened this issue Aug 12, 2024 · 0 comments · Fixed by #4037
Closed

Preserve clause ordering of requires and ensures when internalisig rules #4028

geo2a opened this issue Aug 12, 2024 · 0 comments · Fixed by #4037
Assignees
@goodlyrottenapple

Comments

@geo2a
Copy link
Collaborator

geo2a commented Aug 12, 2024

To enable syntactic simplifications, Booster's internal representation of simplification rules must store the rule's requires clause as an ordered collection, and preserver the user-specified order of conjuncts (subterms if _andBool_).

Currently, we internalise rules' LHS and RHS as Patterns. The requires/ensures clause is then taken to be the patterns' constrains, which are a Set. Moreover, the internalisePredicates function also returns a Set.

We may have to decouple the internalisation routines for rules and patterns a little more to implement this.
@goodlyrottenapple goodlyrottenapple mentioned this issue Aug 15, 2024
Merged
goodlyrottenapple added a commit that referenced this issue Aug 19, 2024
@goodlyrottenapple
Preserve clause ordering of requires and ensures when internalisi…
f1d156f 
…g rules in booster (#4037)

Fixes #4028

---------

Co-authored-by: github-actions <github-actions@github.com>
@goodlyrottenapple goodlyrottenapple mentioned this issue Aug 19, 2024
Merged
rv-jenkins added a commit that referenced this issue Aug 19, 2024
@goodlyrottenapple @rv-jenkins
Remove support for antiLeft rules and aliases (#4039)
4c10181 
Follow up to #4028, which further cleans up the code-base by removing
internalisation of anti-left rules, as these are:
a) unused for over a year now (since #3391)
b) the previous PR essentially left the inernalisation of anti-left
broken, but we wanted to remove it fully in a separate PR for ease of
review.

---------

Co-authored-by: rv-jenkins <admin@runtimeverification.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodlyrottenapple goodlyrottenapple

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@geo2a @goodlyrottenapple