Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private IP address #156

Open
dmerrick opened this issue May 29, 2024 · 1 comment
Open

Add support for private IP address #156

dmerrick opened this issue May 29, 2024 · 1 comment

Comments

@dmerrick
Copy link

Right now the module sets up a public IP address here.

If a user is using self-hosted github/gitlab, there is no need to expose Atlantis publicly.

It would be great if there was an option to deploy atlantis without also creating a public IP

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer label May 29, 2024
@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer label May 29, 2024
@bschaatsbergen
Copy link
Member

bschaatsbergen commented May 29, 2024

Hey @dmerrick, great suggestion! I think this could be a valuable addition to the module. For whoever implements it, note that this will likely require swapping the global load balancer for an internal one. This change could add significant bloat to the module, so we might need to consider a reference implementation or creating a separate module instead of integrating it directly into the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants