Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CloudFormation notifications #507

Open
jhottenstein opened this issue Jul 27, 2020 · 0 comments
Open

Support for CloudFormation notifications #507

jhottenstein opened this issue Jul 27, 2020 · 0 comments
Labels
feature v5 jets v5 issues

Comments

@jhottenstein
Copy link

Summary

Jets uses CloudFormation under the hood to handle deployments. CloudFormation will send stack events to a SNS topic if configured when calling create/update_stack. Allow jets users to configure an SNS topic to receive jets deploy updates

Motivation

We would like to be notified about jets deployments (to enable email/webhook integrations). Our use case is to enable Slack notifications when our app is updated. This provides visiblity to our entire ops team and simplifies debugging production issues.

Guide-level explanation

If desired, add a config variable to application.rb with a SNS topic ARN to enable sending stack updates.

Reference-level explanation

Reading the code, it seems that Jets::CFN::Ship needs to pass notification_arns into the aws sdk client:

    # options common to both create_stack and update_stack
    def stack_options
      {
        stack_name: @parent_stack_name,
        capabilities: capabilities, # ["CAPABILITY_IAM", "CAPABILITY_NAMED_IAM"]
        # disable_rollback: !@options[:rollback],
        notification_arns: @options[:notification_arns]
      }.merge!(template.to_h)
    end

I'm not sure how this project would like to get those values from the user.

Drawbacks

It could increase jets support burden. Setting up SNS topics to forward messages is opaque and could confuse first time users?

Unresolved Questions

@tongueroo tongueroo added the v5 jets v5 issues label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature v5 jets v5 issues
Projects
None yet
Development

No branches or pull requests

2 participants