Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search repo for files with string replacement patterns rather than hard coding a list #590

Open
ianpittwood opened this issue Jul 27, 2023 · 1 comment
Labels
cicd Continuous integration/deployment enhancement New feature or request good first issue Good for newcomers

Comments

@ianpittwood
Copy link
Collaborator

It would be useful to grep for version replacement patterns, such as ^R_VERSION := or ^R_VERSION=, to get the list of files to update instead of having to manually update a hard coded list that could be prone to human error.

We could even write a just command that would find the files matching a specific pattern and then send them as arguments to the sed command.

Originally proposed by @bschwedler in #588 (comment)

@ianpittwood ianpittwood added enhancement New feature or request good first issue Good for newcomers cicd Continuous integration/deployment labels Jul 27, 2023
@bschwedler
Copy link
Contributor

Reported in #613, we will also need to add PYTHON_VERSION_JUPYTER to the list of versions to update, defaulting to the value of PYTHON_VERSION_ALT.

bschwedler added a commit that referenced this issue Aug 9, 2023
Closes #613

The current `just` automation to update python versions does not
currently apply to `PYTHON_VERSION_JUPYTER`.

This is a one-off fix until we address this fully in #590
bschwedler added a commit that referenced this issue Aug 9, 2023
Closes #613

The current `just` automation to update python versions does not
currently apply to `PYTHON_VERSION_JUPYTER`.

This is a one-off fix until we address this fully in #590
bschwedler added a commit that referenced this issue Aug 9, 2023
Closes #613

The current `just` automation to update python versions does not
currently apply to `PYTHON_VERSION_JUPYTER`.

This is a one-off fix until we address this fully in #590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Continuous integration/deployment enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants