Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support https://github.com/rails/rails/pull/46273 #2310

Open
yahonda opened this issue Oct 31, 2022 · 0 comments
Open

Support https://github.com/rails/rails/pull/46273 #2310

yahonda opened this issue Oct 31, 2022 · 0 comments

Comments

@yahonda
Copy link
Collaborator

yahonda commented Oct 31, 2022

Steps to reproduce

This is a placeholder to support rails/rails#46273

Expected behavior

Oracle enhanced adapter execute method should support allow_retry argument.

Actual behavior

This change has not been implemented yet.

System configuration

Rails version: master

Oracle enhanced adapter version: master

Ruby version:

Oracle Database version:
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 19, 2024
@andynu
Add allow_retry kwarg to execute
5797871 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
@andynu andynu mentioned this issue Mar 19, 2024
Closed
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 19, 2024
@andynu
Add allow_retry kwarg to execute
7e566d5 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 19, 2024
@andynu
Add allow_retry kwarg to execute
c468f3c 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 25, 2024
@andynu
Add allow_retry kwarg to execute
d931451 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
@andynu andynu mentioned this issue Mar 25, 2024
Merged
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 25, 2024
@andynu
Add allow_retry kwarg to execute
bb49ea0 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 25, 2024
@andynu
Add allow_retry kwarg to execute
113446a 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
andynu added a commit to andynu/oracle-enhanced that referenced this issue Mar 25, 2024
@andynu
Add allow_retry kwarg to execute
49bdc42 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
andynu added a commit to andynu/oracle-enhanced that referenced this issue Apr 1, 2024
@andynu
Add allow_retry kwarg to execute
b992d08 
This extends the existing class level auto_retry functionality to
optionally allow an allow_retry boolean kwarg to allow retry of specific
queries.

This PR preserves the requirement that `autocommit?` be enabled which is the
safer choice.

```
  def with_retry(allow_retry: false) # :nodoc:
    should_retry = (allow_retry || self.class.auto_retry?) && autocommit?
```

See issue rsim#2310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yahonda