Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Support address alias name #2772

Open
jolestar opened this issue Oct 16, 2024 · 1 comment
Open

[CLI] Support address alias name #2772

jolestar opened this issue Oct 16, 2024 · 1 comment
Assignees
Labels
help wanted Extra attention is needed proposal New external API or other notable changes skill::rust Need the rust language skill to complete the issue
Milestone

Comments

@jolestar
Copy link
Contributor

Proposal Details

  1. Support sets alias names to address and saves them to the keystore.
  2. CLI auto-loads the address mappings(name -> address) from the keystore and adds them to WalletContext when executing a command.

pub fn add_address_mapping(&mut self, name: String, address: RoochAddress) {
self.address_mapping.insert(name, address.into());
}

The cli will support the name as address arguments.

rooch account transfer --sender alice --to bob
rooch move run --function alice::my_module::my_function
@jolestar jolestar added the proposal New external API or other notable changes label Oct 16, 2024
@jolestar jolestar added this to the Rooch v0.8 milestone Oct 16, 2024
@jolestar jolestar added help wanted Extra attention is needed skill::rust Need the rust language skill to complete the issue labels Oct 16, 2024
@newraina
Copy link
Contributor

@jolestar may I take it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed proposal New external API or other notable changes skill::rust Need the rust language skill to complete the issue
Projects
Status: No status
Development

No branches or pull requests

2 participants