Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Submodules as main-module in rio.toml #156

Open
mad-moo opened this issue Oct 16, 2024 · 0 comments
Open

Disallow Submodules as main-module in rio.toml #156

mad-moo opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement Improves on existing functionality - NOT a new feature

Comments

@mad-moo
Copy link
Contributor

mad-moo commented Oct 16, 2024

It is currently possible to specify submodules as the app's main module. For example, the rio.App can be located at foo.bar instead of foo. While this is convenient and seems to sometimes work, it is not actually supported.

Rio relies on being able to determine the location of the file, by looking for a file/folder with that name in the project directory. Submodules don't adhere to this though - the Python code can run arbitrary operations, which makes it impossible to locate the correct files in general.

If we want to support this, all code should be reviewed and possibly some restrictions defined & documented. Until then, Rio should explicitly check to make sure the specified module is not a submodule and notify the user.

@mad-moo mad-moo added bug Something isn't working enhancement Improves on existing functionality - NOT a new feature labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improves on existing functionality - NOT a new feature
Projects
None yet
Development

No branches or pull requests

2 participants