Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GP_UCB _beta is NaN #329

Open
nickanthony-dgl opened this issue May 31, 2023 · 1 comment
Open

GP_UCB _beta is NaN #329

nickanthony-dgl opened this issue May 31, 2023 · 1 comment
Assignees
@costashatz
Labels
bug

Comments

@nickanthony-dgl
Copy link

On the first iteration of the optimization when using the GP_UCB acquisition function the iteration is 0. This causes nt to be 0 which causes std::log(nt * pi2 / delta3) to be NaN. This results in all values returned by operator() also being NaN for this iteration. Looking at this reference seems to imply that the iteration (referred to as t in the paper) should start at 1 rather than 0.
@costashatz costashatz self-assigned this Aug 4, 2023
@costashatz costashatz added the bug label Aug 4, 2023
@costashatz
Copy link
Member

@nickanthony-dgl you are right. Thanks for catching this. I will fix this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@costashatz costashatz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@costashatz @nickanthony-dgl