Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heuristic stacks video frames rather than giving them their own 2d views #7821

Open
jleibs opened this issue Oct 17, 2024 · 2 comments
Open

Heuristic stacks video frames rather than giving them their own 2d views #7821

jleibs opened this issue Oct 17, 2024 · 2 comments
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Milestone
Next patch release

Comments

@jleibs
Copy link
Member

jleibs commented Oct 17, 2024

VideoAssets should follow the same heuristics as images
@jleibs jleibs added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Oct 17, 2024
@jleibs jleibs added this to the Next patch release milestone Oct 17, 2024
@emilk
Copy link
Member

emilk commented Oct 21, 2024

In particular: rerun folder_of_videos/ should produce one space-view per video

@emilk emilk self-assigned this Oct 21, 2024
@emilk emilk mentioned this issue Oct 21, 2024
Merged
6 tasks
@emilk
Copy link
Member

emilk commented Oct 21, 2024 •
edited
Loading

Part of the work is done in:

For the second half, we need to do one or both of the following:

@emilk emilk removed their assignment Oct 21, 2024
emilk added a commit that referenced this issue Oct 22, 2024
@emilk
Refactor MaxImageDimensionSubscriber (#7850)
749b58b 
### What
* Part of #7821
* Bonus: better profiling of video loading

The change is that `MaxImageDimensionSubscriber` parses each `.mp4` to
figure out its size…
…except I disabled that check last-second because we don't have access
to the `VideoCache`, and so this PR would lead to each video getting
parsed _twice_.

Still, I would like to get this PR merged as a necessary refactor and
generally improved structure.

This is where we're heading:

![image](https://github.com/user-attachments/assets/69c8d206-6332-40c3-aa66-bb96ada3772c)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7850?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7850?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7850)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
Next patch release
Development

No branches or pull requests
2 participants
@emilk @jleibs