Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase thickness of lines drawn between keypoint connections #5721

Open
palol opened this issue Mar 28, 2024 · 4 comments
Open

Increase thickness of lines drawn between keypoint connections #5721

palol opened this issue Mar 28, 2024 · 4 comments
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself

Comments

@palol
Copy link

palol commented Mar 28, 2024

Is your feature request related to a problem? Please describe.
I have not been able to find an example that demonstrates drawing thicker/thinner keypoint skeletons using the AnnotationContext class. Currently, it seems like the only solution is to instead draw the skeleton using LineStrips.

Describe the solution you'd like
Would it be possible to expose another variable like radii to the AnnotationContext class, which would enable adjusting the thickness of the drawn keypoint skeleton.

Describe alternatives you've considered
Alternatively, including a code example using LineStrips to draw a custom skeleton for a set of keypoints.

Additional context
Example change

rr.log(
        "/",
        rr.AnnotationContext(
            rr.ClassDescription(
                info=rr.AnnotationInfo(id=0, label="Person"),
                keypoint_annotations=[rr.AnnotationInfo(id=lm.value, label=lm.name) for lm in mp_pose.PoseLandmark],
                keypoint_connections=mp_pose.POSE_CONNECTIONS,
                **radii=0.25**
            )
        ),
        timeless=True,
    )
@palol palol added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 28, 2024
@jleibs jleibs added 📺 re_viewer affects re_viewer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 28, 2024
@jleibs
Copy link
Member

jleibs commented Mar 28, 2024

Makes sense.

In the short term you can actually influence this behavior by selecting the space view and then modifying the "Default size" of line radius.

Exa:
image

However, I agree we should be able to control this explicitly via the API.

@palol
Copy link
Author

palol commented Mar 29, 2024

Makes sense.

In the short term you can actually influence this behavior by selecting the space view and then modifying the "Default size" of line radius.

However, I agree we should be able to control this explicitly via the API.

Thank you! I new there had to be a global setting somewhere in the viewer.

@Wumpf
Copy link
Member

Wumpf commented Apr 23, 2024

As pointed out in

this should naturally also be per class, not just on the entire context

@Wumpf
Copy link
Member

Wumpf commented Oct 22, 2024

looks like we regressed further on this: now the workaround doesn't work either anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

3 participants