-
Notifications
You must be signed in to change notification settings - Fork 21
cdc‐review
- DB scheme versioning need to be changed/ does not correspond to our release cycle
- I have seen some parameters hard-coded in config xml file which some actually be taken dynamically from properties
- there are new places with print out directly to console (this we don't want, everything should be properly logged)
- cypress (javascript) - for testing? is this free/ open source? careful with that for now
- the docker setup is not very nice but OK, we probably do it differently anyway
- odm - committed was again all generated classes for odm module (this is also something we do not want)
- actually those odm module classes seem to be the majority of changed code (did not really change, these are static files that normally can get generated during build and packed into jar)
- updated jmesa library (interesting) we should have a look on that (AbstractTableFactory)
- jquery life patching on ServletViews, was this way to move to new jquery?
- different study site statistics (I guess from randomisation perspective)
- forcing email uniqueness for user account (this not sure if we want)
web/src/main/java/org/akaza/openclinica/controller/OAuthAuthentication.java
web/src/main/java/org/akaza/openclinica/controller/OAuthController.java
web/src/main/java/org/akaza/openclinica/web/filter/OpenClinicaUsernamePasswordAuthenticationFilter.java
web/src/main/resources/org/akaza/openclinica/applicationContext-security.xml
web/src/main/webapp/WEB-INF/jsp/include/navBar.jsp
web/src/main/webapp/WEB-INF/jsp/login/login.jsp
web/src/main/webapp/WEB-INF/jsp/welcome.jsp
web/src/main/webapp/WEB-INF/pages-servlet.xml
web/src/main/webapp/WEB-INF/web.xml
we should also compare with huter because they actually have this running with real Keycloak and somehow I think the approach there could teach us something
web/src/main/resources/org/akaza/openclinica/i18n/meddra.properties
web/src/main/webapp/includes/meddra/api.js
web/src/main/webapp/includes/meddra/estilo.css
web/src/main/webapp/includes/meddra/estilo.css
web/src/main/webapp/includes/meddra/form.html
web/src/main/webapp/includes/meddra/meddra-browser-api.jsp
web/src/main/resources/org/akaza/openclinica/i18n/whodrug.properties
web/src/main/webapp/includes/whodrug/api.js
web/src/main/webapp/includes/whodrug/resources/bootstrap.min.css
web/src/main/webapp/includes/whodrug/resources/jquery-3.6.0.min.js
web/src/main/webapp/includes/whodrug/resources/string-similarity.min.js
web/src/main/webapp/includes/whodrug/whodrug.jsp