Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two liveness checks when using decoy registration with sharing over API #58

Open
jmwample opened this issue Dec 3, 2020 · 0 comments
Open

Comments

@jmwample
Copy link
Member

jmwample commented Dec 3, 2020

Issue

The delay on the client affords one liveness check but not two serially which is what is currently happening for registrations received over the decoy registration channel then shared over the registration API.

We need to reduce this to one liveness check.

Possible Solutions

Option 1

Add a flags field. to the clientToApi structure to indicate that a registration has or has not been scanned.

Option 2

Create a new registration endpoint for registrations coming from stations, when distributed are given the RegistrationSource_DetectorPrescan tag in the ZMQPayload to indicate to stations not to scan them. The API endpoint to share registrations over is defined in the station application config file.

Option 3

Add RegistrationSource as a field to ClientToApi effetively merging it with ZMQPayload and allow clients of the API to specify the RegistrationSource, i.e. allow stations sharing registrations over the API to use the RegistrationSource_DetectorPrescan to indicate that the registration has already been checked for liveness and stations don't need to do it again.

Option 4

Perform liveness scan on registration API machine, stations accept any registrations from API without scanning.

Relevant Code locations

Registration api translates ClientToSpi to ZMQPayload

Station App attempts to check for DetectorPrescan registration source

Station creates ClientToAPI for sharing registrations

Station shares registrations over API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant