From 77b964591120f4ec767869d70c7ff7f0bd257da8 Mon Sep 17 00:00:00 2001 From: Nicolae Vartolomei Date: Wed, 23 Oct 2024 16:14:15 +0100 Subject: [PATCH] bazel: make state_machine_registry.h a module Less components depend on cluster. Nicer build graph. --- src/v/cluster/BUILD | 14 +++++++++++++- src/v/datalake/coordinator/BUILD | 2 +- src/v/kafka/server/BUILD | 1 + src/v/transform/stm/BUILD | 5 ++++- 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/v/cluster/BUILD b/src/v/cluster/BUILD index 037237913348..c3651108a4f1 100644 --- a/src/v/cluster/BUILD +++ b/src/v/cluster/BUILD @@ -251,6 +251,18 @@ redpanda_cc_library( visibility = ["//visibility:public"], ) +redpanda_cc_library( + name = "state_machine_registry", + hdrs = [ + "state_machine_registry.h", + ], + include_prefix = "cluster", + visibility = ["//visibility:public"], + deps = [ + "//src/v/raft", + ], +) + redpanda_cc_library( name = "cluster", srcs = [ @@ -574,7 +586,6 @@ redpanda_cc_library( "shard_table.h", "simple_batch_builder.h", "snapshot.h", - "state_machine_registry.h", "tm_stm.h", "tm_stm_types.h", "topic_configuration.h", @@ -620,6 +631,7 @@ redpanda_cc_library( ":partition_balancer_rpc", ":run_quota", ":self_test_rpc", + ":state_machine_registry", ":topic_recovery_status_rpc", ":tx_gateway_rpc", ":tx_manager_migrator_rpc", diff --git a/src/v/datalake/coordinator/BUILD b/src/v/datalake/coordinator/BUILD index ac537fba7e95..bb5bc6e23153 100644 --- a/src/v/datalake/coordinator/BUILD +++ b/src/v/datalake/coordinator/BUILD @@ -186,7 +186,7 @@ redpanda_cc_library( ":model", ":state", ":state_update", - "//src/v/cluster", + "//src/v/cluster:state_machine_registry", "//src/v/datalake:logger", "//src/v/model", "//src/v/raft", diff --git a/src/v/kafka/server/BUILD b/src/v/kafka/server/BUILD index 2c7fe081b644..e8799e2c5a74 100644 --- a/src/v/kafka/server/BUILD +++ b/src/v/kafka/server/BUILD @@ -166,6 +166,7 @@ redpanda_cc_library( "//src/v/bytes:scattered_message", "//src/v/cloud_storage", "//src/v/cluster", + "//src/v/cluster:state_machine_registry", "//src/v/config", "//src/v/container:chunked_hash_map", "//src/v/container:fragmented_vector", diff --git a/src/v/transform/stm/BUILD b/src/v/transform/stm/BUILD index ebcbe9e511e6..d468eaad51b2 100644 --- a/src/v/transform/stm/BUILD +++ b/src/v/transform/stm/BUILD @@ -8,10 +8,13 @@ redpanda_cc_library( hdrs = [ "transform_offsets_stm.h", ], + implementation_deps = [ + "//src/v/cluster", + ], include_prefix = "transform/stm", visibility = ["//visibility:public"], deps = [ - "//src/v/cluster", + "//src/v/cluster:state_machine_registry", "//src/v/model", "@seastar", ],