Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Vietnamese Translation Progress #345

Open
gaearon opened this issue Apr 25, 2023 · 33 comments
Open

New Vietnamese Translation Progress #345

gaearon opened this issue Apr 25, 2023 · 33 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gaearon
Copy link
Member

gaearon commented Apr 25, 2023

Maintainers

For New Translators

To translate a page:

  1. Check that no one else has claimed your page in the checklist and comments below.
  2. Comment below with the name of the page you would like to translate. Take only one page at a time.
  3. Clone this repo, translate your page, and submit a pull request!

Before contributing, read the glossary and style guide to understand how to translate various technical and React-specific terms.

You can use the Crowdin as a base for your translation. Make sure to compare the content with the current React website to make sure everything is up to date! (NOTE: delete this if the language doesn't have any Crowdin contributions)

Please be prompt with your translations! If you find that you can't commit anymore, let the maintainers know so they can assign the page to someone else.

For maintainers

When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:

* [x] Some Page (@somebody) #12345

When PRs are merged, make sure to mark that page as completed!

Main Content

To do before releasing as an "official" translation. Please translate these pages first.

Note that each section has an index page, which needs to be translated too.

Learn React

API Reference

Navigation and UI

We suggest to leave most of the UI translation until the end. We plan to do some invasive changes to the website folder layout and components, so postponing this until your translation is almost complete would make it easier to merge the changes from our side later. It might make sense to translate the homepage above the fold early, but leave the rest for later. As individual pages get translated, you can change the page titles in the corresponding sidebar files. Finally, when you're translating the navigation, make sure to test both desktop and mobile layouts.

  • Homepage (currently in HomeContent.js)
  • Sidebars (currently in src/sidebar*.json)
  • Top-level navigation (currently in TopNav.tsx)

When You're Ready...

After everything above is translated, add your language to deployedLanguages in Seo.tsx of the original reactjs/react.dev repository.

Secondary Content

These API pages should ideally be translated too, but they're less urgent and can be done after the others:

  • Legacy React APIs
    • Children
    • cloneElement
    • Component
    • createElement
    • createFactory
    • createRef
    • isValidElement
    • PureComponent

Optional Content

These aren't the main translation targets, but if you'd like to do them, feel free to expand the list to include their subpages:

  • Community
  • Blog
  • Warnings
@gaearon gaearon pinned this issue Apr 25, 2023
@gaearon gaearon added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 25, 2023
@Quynh-Nguyen
Copy link
Contributor

Hi all, I will pick useCallback hook page

https://vi.react.dev/reference/react/useCallback

@huongphamx
Copy link

huongphamx commented Apr 25, 2023

Hi all, I will translate Tutorial: Tic-Tac-Toe page
https://vi.react.dev/learn/tutorial-tic-tac-toe

I've added a draft PR: #346

@ninh-nd
Copy link
Contributor

ninh-nd commented Apr 25, 2023

Hi all, I will pick the Installation index page
https://react.dev/learn/installation

@NghiaDangTran
Copy link
Contributor

Hi guys, I will pick the Thinking in React page
https://vi.react.dev/learn/thinking-in-react

@gaearon
Copy link
Member Author

gaearon commented Apr 25, 2023

@nampdn @ltmylinh @cuongtran8 @Ryan-LT

Can you please confirm whether you'd be able to steer and maintain this translation? We'd like to get https://github.com/reactjs/translations.react.dev/blob/main/langs/vi.json updated to list active maintainers. Thank you!

@ltmylinh
Copy link
Collaborator

@nampdn @ltmylinh @cuongtran8 @Ryan-LT

Can you please confirm whether you'd be able to steer and maintain this translation? We'd like to get https://github.com/reactjs/translations.react.dev/blob/main/langs/vi.json updated to list active maintainers. Thank you!

Hi @gaearon, yes I will be able to do it.

@Ryan-LT
Copy link
Member

Ryan-LT commented Apr 26, 2023

@gaearon I can help with that.

@bboy114crew
Copy link
Contributor

Hi guys, I will pick the Writing Markup with JSX page.
https://react.dev/learn/writing-markup-with-jsx

@ltmylinh
Copy link
Collaborator

ltmylinh commented Apr 26, 2023

@nampdn @ltmylinh @cuongtran8 @Ryan-LT

Can you please confirm whether you'd be able to steer and maintain this translation? We'd like to get https://github.com/reactjs/translations.react.dev/blob/main/langs/vi.json updated to list active maintainers. Thank you!

Hi @gaearon , There are some texts that are being rendered in English from the React components.
So Should we translate these texts in the component itself - I mean we modify these texts in components directly? or Should we leave it as English on our website? or Should we modify these components so we can pass these texts as props?
Do you have any thoughts on this? Thanks.

@viettrung9012
Copy link
Contributor

Hi all, I would like to pick the useDebugValue page

@ThangHuuVu
Copy link
Contributor

Hi all, I would like to pick the State as a Snapshot page

@gaearon
Copy link
Member Author

gaearon commented Apr 26, 2023

@ltmylinh

Should we translate these texts in the component itself - I mean we modify these texts in components directly?

I think it's up to individual translations to decide. I'm not sure. I could see it going either way — I suggest to decide this with other translation maintainers.

@leduc1901
Copy link
Contributor

leduc1901 commented Apr 28, 2023

Hi all, I have several pull requests waiting to be reviewed and merged. Could the maintainers please help me out by reviewing them?
My PRs include:

@leduc1901
Copy link
Contributor

leduc1901 commented Apr 28, 2023

Beside, I want to pick the "Fragment" page: https://vi.react.dev/reference/react/Fragment and the Profiler page
Thanks in advance

@ninh-nd
Copy link
Contributor

ninh-nd commented Apr 28, 2023

I will translate the Your First Component page https://react.dev/learn/your-first-component

@nguyentran-se
Copy link
Contributor

nguyentran-se commented Apr 29, 2023

Hi guys, I would like to translate useState page: https://react.dev/reference/react/useState

@hminh2027
Copy link
Contributor

Hi all, I would like to pick the Render and Commit page.
https://react.dev/learn/render-and-commit

@phuc1nguyen
Copy link

phuc1nguyen commented Apr 30, 2023

Hi @gaearon, I think you should update the glossary link to #2 instead of this issue's url.

Before contributing, read the glossary and style guide to understand how to translate various technical and React-specific terms.

@phuc1nguyen
Copy link

phuc1nguyen commented Apr 30, 2023

Hi all, I would like to translate Responding to Events page.
https://react.dev/learn/responding-to-events

@ltmylinh
Copy link
Collaborator

ltmylinh commented May 1, 2023

Hi @gaearon, I think you should update the glossary link to #2 instead of this issue's url.

Before contributing, read the glossary and style guide to understand how to translate various technical and React-specific terms.

updated. Thanks.

@leduc1901
Copy link
Contributor

Hi, I will translate the lazy page: https://vi.react.dev/reference/react/lazy
Thanks

@leduc1901
Copy link
Contributor

Hi, I will translate the StrictMode page: https://vi.react.dev/reference/react/StrictMode
Thanks

@NghiaDangTran
Copy link
Contributor

Hi guys i will translate the Reacting to Input with State page

@hminh2027
Copy link
Contributor

hminh2027 commented May 10, 2023

Hi all, I would like to pick the Rendering Lists page.
https://react.dev/learn/rendering-lists

@phuc1nguyen
Copy link

Hi, I'm translating State: A Component's Memory page next.
https://react.dev/learn/state-a-components-memory

@Phonng
Copy link

Phonng commented Aug 22, 2023

Hi all, I would like to translate the <Suspense> page next.
https://vi.react.dev/reference/react/Suspense

@ductbuix
Copy link

ductbuix commented Nov 21, 2023

Hi there, I'd like to take the useEffect api reference, or anything that I can help with, Code Review maybe. cc @gaearon

@hoangtrung99
Copy link
Contributor

Hi all, I would like to translate useSyncExternalStore page.

@thienna
Copy link

thienna commented Apr 22, 2024

Hi there, I'd like to take the react-dom/server, cc @gaearon

@chrisvn188
Copy link
Contributor

Hi there, I would like to translate the learn/updating-objects-in-state page if it's available. Thank you!

@chrisvn188
Copy link
Contributor

Hi there, I would like to translate the learn/updating-arrays-in-state page. Thank you!

@hungcung2409
Copy link

Hi there, I'd like to translate react-dom/flushSync page. Thanks all

@thangved
Copy link

Hi all, I will pick Choosing the State Structure page. Thank all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests