Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Event Handler Properties Change on Shape Ignored? #65

Open
joewood opened this issue Sep 24, 2015 · 1 comment
Open

Event Handler Properties Change on Shape Ignored? #65

joewood opened this issue Sep 24, 2015 · 1 comment

Comments

@joewood
Copy link

joewood commented Sep 24, 2015

I hit a problem where subsequent render iterations on a Shape with a key in a collection didn't modify the property. The original bound mousedown event handler was still being used by the ART Shape. Checking the code, does Shape process componentWillReceiveProps ? I can see the call to applyNodeProps but it's not clear if new event handlers are re-applied.

@sebmarkbage
Copy link
Contributor

It should: https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L354

And the listeners should be replaced: https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L277

Do you have a reproducible example or perhaps a unit test?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants