Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check RayCluster ray job submit can successfully create a job by running it in the head Pod #2451

Open
Tracked by #2310
MortalHappiness opened this issue Oct 18, 2024 · 1 comment · May be fixed by #2459
Open
Tracked by #2310
Assignees
Labels
ci good first issue Good for newcomers

Comments

@MortalHappiness
Copy link
Member

MortalHappiness commented Oct 18, 2024

This is a subtask of #2310. See the parent issue for more information.

Implementation Details

  • Implement the EasyJobRule here with Golang.
    class EasyJobRule(Rule):
    """Submit a very simple Ray job to test the basic functionality of the Ray cluster."""
    def assert_rule(self, custom_resource=None, cr_namespace='default'):
    headpod = get_head_pod(cr_namespace)
    headpod_name = headpod.metadata.name
    pod_exec_command(headpod_name, cr_namespace,
    "python -c \"import ray; ray.init(); print(ray.cluster_resources())\"")
  • Implement this check as a utility function so that other tests can use it
  • Add the test after this line
    test.Eventually(GetWorkerPods(test, rayCluster), TestTimeoutShort).Should(gomega.WithTransform(AllPodsRunningAndReady, gomega.BeTrue()))
@MortalHappiness MortalHappiness self-assigned this Oct 18, 2024
@MortalHappiness MortalHappiness changed the title Check ray job submit can successfully create a job by running it in the head Pod Check RayCluster ray job submit can successfully create a job by running it in the head Pod Oct 18, 2024
@MortalHappiness MortalHappiness added the good first issue Good for newcomers label Oct 18, 2024
@CheyuWu
Copy link

CheyuWu commented Oct 18, 2024

Hi @MortalHappiness I'd like to help with this

@CheyuWu CheyuWu linked a pull request Oct 21, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants